Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#1834 closed change (worksforme)

Add public domain suffix import to buildtools

Reported by: kzar Assignee:
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: sebastian, trev Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

Description (last modified by sebastian)

Background

Mozilla maintain a list of public domain suffixes online. We use this in our extensions, but we store it in a different format.

Currently keeping our copies of the list up to date is a manual process and this is time consuming. Hence our list is outdated most of the time.

What to change

Implement .build.py -t chrome getpublicsuffixlist. This command should:

  1. Download Mozilla's Public Suffix List
  2. Convert it to the format used internally by Adblock Plus
  3. Update lib/publicSuffixList.js

Change History (7)

comment:1 Changed 3 years ago by kzar

  • Cc kzar added

comment:2 Changed 3 years ago by kzar

  • Cc kzar removed

comment:3 Changed 3 years ago by kzar

  • Description modified (diff)

comment:4 Changed 3 years ago by sebastian

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set
  • Summary changed from Add public domain suffix import feature to buildtools to Add public domain suffix import to buildtools

comment:5 Changed 3 years ago by trev

  • Cc trev added
  • Resolution set to worksforme
  • Status changed from new to closed

It's build.py -t chrome updatepsl actually.

comment:6 Changed 3 years ago by sebastian

Interesting, didn't know that. Do you think we should update the public suffix list during the release process, just like we do for translations?

comment:7 Changed 3 years ago by trev

Yes, that probably makes sense.

Note that there is a second copy of it in the libadblockplus repository, we probably want to keep it in sync.

Note: See TracTickets for help on using tickets.