Changes between Version 3 and Version 4 of Ticket #1834


Ignore:
Timestamp:
01/20/2015 02:06:01 PM (5 years ago)
Author:
sebastian
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1834

    • Property Priority changed from Unknown to P3
    • Property Ready set
    • Property Summary changed from Add public domain suffix import feature to buildtools to Add public domain suffix import to buildtools
  • Ticket #1834 – Description

    v3 v4  
    22Mozilla maintain [https://publicsuffix.org/list/effective_tld_names.dat a list of public domain suffixes online]. We use this in our extensions, but we store it in a different format. 
    33 
    4 Currently keeping our copies of the list up to date is a manual process and this is time consuming. We want to update build tools to add a way to import the list automatically. 
     4Currently keeping our copies of the list up to date is a manual process and this is time consuming. Hence our list is outdated most of the time. 
    55 
    66=== What to change === 
    7 Write a script to import [https://publicsuffix.org/list/effective_tld_names.dat the list] into a JSON format [https://github.com/adblockplus/adblockpluschrome/blob/master/lib/publicSuffixList.js as we use in our Chrome extension]. 
     7Implement `.build.py -t chrome getpublicsuffixlist`. This command should: 
    88 
    9 The values for each key in the JSON output should be the number of domain parts (subdomains) before the listed domain that are also public + 1. 
    10  
    11 So for example, until recently you could not register ".uk" domains directly, instead only domains like ".co.uk" or ".org.uk". Therefore the key "uk" would have the value 2 as there was always one public subdomain before it. (Now however you can register ".uk" domains directly so "uk" should have a value of 1, and the other possible public subdomains like "co.uk" should be listed separately with the value of 1.) 
    12  
    13 For an explanation of the format of the list hosted by Mozilla [https://publicsuffix.org/list/ have a look at this documentation]. 
     91. Download [https://publicsuffix.org/list/ Mozilla's Public Suffix List] 
     102. Convert it to the [https://github.com/adblockplus/adblockpluschrome/blob/master/lib/publicSuffixList.js format used internally] by Adblock Plus 
     113. Update `lib/publicSuffixList.js`