Opened 5 years ago

Closed 20 months ago

Last modified 19 months ago

#1846 closed change (fixed)

Remove the locale parameter of Notification.getLocalizedTexts

Reported by: fhd Assignee: Yael
Priority: P4 Milestone:
Module: Core Keywords: goodfirstbug
Cc: kzar, sergz, greiner, Ross Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://github.com/adblockplus/adblockpluscore/pull/4

Description (last modified by fhd)

Background

Notification.getLocalizedTexts currently has a locale parameter that makes it possible to retrieve the text for any locale, not just the application locale. This is completely unused (other than in tests), and there's no real point in getting texts for a different language (falling back to the default locale for missing texts already happens automatically).

What to change

Remove the locale parameter from Notification.getLocalizedTexts.

Change History (7)

comment:1 Changed 5 years ago by fhd

  • Description modified (diff)

comment:2 Changed 22 months ago by sergz

  • Keywords goodfirstbug added
  • Ready set
  • Tester set to Unknown
  • Verified working unset

comment:3 Changed 20 months ago by abpbot

comment:4 Changed 20 months ago by kzar

  • Cc kzar sergz fhd greiner Ross added
  • Priority changed from Unknown to P4
  • Resolution set to fixed
  • Review URL(s) modified (diff)
  • Status changed from new to closed

Sergz and I reviewed the change, I've checked it still lints and the unit tests pass. I couldn't figure out how to trigger this code path for real however, anyone have any ideas how? I'd like to update the Hints for Testers section.

comment:5 Changed 20 months ago by kzar

  • Cc fhd removed

comment:6 Changed 20 months ago by kzar

  • Owner set to Yael

comment:7 Changed 19 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. I tested this by checking that notifications were localized and that the fallback to en-US still works as expected.

ABP 3.0.2.1983
Chrome 49 / 65 / Windows 10
Opera 36 / 51 / Windows 7

Note: See TracTickets for help on using tickets.