Opened 5 years ago

Last modified 21 months ago

#1846 closed change

Remove the locale parameter of Notification.getLocalizedTexts — at Version 1

Reported by: fhd Assignee:
Priority: P4 Milestone:
Module: Core Keywords: goodfirstbug
Cc: kzar, sergz, greiner, Ross Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://github.com/adblockplus/adblockpluscore/pull/4

Description (last modified by fhd)

Background

Notification.getLocalizedTexts currently has a locale parameter that makes it possible to retrieve the text for any locale, not just the application locale. This is completely unused (other than in tests), and there's no real point in getting texts for a different language (falling back to the default locale for missing texts already happens automatically).

What to change

Remove the locale parameter from Notification.getLocalizedTexts.

Change History (1)

comment:1 Changed 5 years ago by fhd

  • Description modified (diff)
Note: See TracTickets for help on using tickets.