Opened 5 years ago

Closed 5 years ago

#1852 closed defect (fixed)

Safari fails to parse empty URLs

Reported by: scump Assignee: sebastian
Priority: P1 Milestone: Adblock-Plus-1.8.11-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Safari
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/6289648649240576

Description (last modified by mapx)

Environment

OS X 10.10.1, Safari 8.0.2.
ABP 1.8.10.1319 - 1323

Observed behaviour

I updated from 1319 to 1323 and Adblock Plus doesn't work anymore, the first thing I noticed is that when I click on ABP's icon its menu appears but I can't click on anything on the menu, everything is like "frozen", but the biggest problem is that for some reason ABP doesn't block any ad at all. So I went back to the stable 1.8.10 for the moment and no problem.

Change History (4)

comment:1 Changed 5 years ago by mapx

  • Cc sebastian added
  • Component changed from Unknown to Platform
  • Description modified (diff)
  • Summary changed from The latest devbuild doesn't work to Safari: The latest devbuild doesn't work ABP 1.8.10.1319 - 1323

comment:2 Changed 5 years ago by sebastian

  • Cc sebastian removed
  • Owner set to sebastian
  • Priority changed from Unknown to P1
  • Ready set
  • Summary changed from Safari: The latest devbuild doesn't work ABP 1.8.10.1319 - 1323 to Safari fails to parse empty URLs

This regression was introduced by #1841. Apparently Safari can't parse empty URLs. Hence new URL("") results in a TypeError, and prevents further code from execution.

comment:3 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.