Opened 5 years ago

Closed 5 years ago

#1853 closed change (fixed)

Move filter generation into the background page utilizing URL utils available there

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.8.12-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By: #1801
Blocking: #1282, #2076 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/6174977720057856

Description (last modified by sebastian)

Background

With #1801 we introduced URL objects and some IDN-aware helper functions in the background page. But the "Block element" functionality still generates filters in the content script, handling URLs in an obsolete way. In order to unify code and make "Block element" correctly handle IDN domains we have to move the filter generation to the background page. This will also simplify the implementation of #1282.

What to change

Move the generation of filters from the content script to the background page, parsing/resolving URLs there.

Change History (4)

comment:1 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by sebastian

  • Blocked By 1801 added; 1802 removed
  • Description modified (diff)

comment:3 Changed 5 years ago by sebastian

  • Blocking 2076 added

comment:4 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.