Changes between Version 1 and Version 2 of Ticket #1864


Ignore:
Timestamp:
01/25/2015 12:04:15 PM (5 years ago)
Author:
sebastian
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1864 – Description

    v1 v2  
    332. Click the ABP icon 
    443. Choose "Block element" 
    5 4. Click the NYT logo 
     54. Click the top banner with the NYT logo 
    66 
    77=== Observed behaviour === 
    8 The logo stays highlighted in yellow (as before clicking). And `TypeError: Cannot read property 'description' of undefined` shows up in the JavaScript console. That's because there is another element with the class `branding`, inside a hidden element. Hence `addElementOverlay()` returns `null`. However, this case isn't handled in `highlightWithOverlay()`, resulting in that error. 
     8The banner stays highlighted in yellow (as before clicking). And `TypeError: Cannot read property 'description' of undefined` shows up in the JavaScript console. That's because there is another element with the class `branding`, inside a hidden element. Hence `addElementOverlay()` returns `null`. However, this case isn't handled in `highlightWithOverlay()`, resulting in that error. 
    99 
    1010=== Expected behaviour ===