Opened 5 years ago

Closed 5 years ago

#1868 closed defect (fixed)

"Block element" cannot handle <area> elements

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.8.11-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/6022881116946432
http://codereview.adblockplus.org/5173617369284608

Description

How to reproduce

  1. Go to http://thewml.org/example/demo/d_incl_imp_csmap/demo.html
  2. Click the ABP icon
  3. Choose "Block element"
  4. Click the image

Observed behaviour

The image is neither highlighted nor does the dialog to add filters show up. Note that <area> elements are used to divide the image into clickable areas.

Expected behaviour

The image should be highlighted and upon clicking the dialog should show up suggesting to add a filter to block that image.

Change History (5)

comment:1 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 5 years ago by sebastian

  • Resolution fixed deleted
  • Status changed from closed to reopened

The fix implemented doesn't work with the "Block element" context menu item.

comment:4 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

comment:5 Changed 5 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.