Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#189 closed change (fixed)

Implement API changes from #117, #153, #192 in Chrome and libadblockplus

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-1.8-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By: #117, #153, #192
Blocking: #204 Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6658724257071104/
http://codereview.adblockplus.org/5442569823584256/
http://codereview.adblockplus.org/5740786045943808/
http://codereview.adblockplus.org/4692713899294720/

Description (last modified by trev)

Background

#117, #153 and #192 implemented some changes to our core APIs. #117 introduced Utils.yield(). #153 removed the fallback to defaults/patterns.ini when there is no patterns.ini file, instead FilterStorage.firstRun flag was introduced. #192 removed encode and decode parameters from FilterStorage.readFromFile() and FilterStorage.writeFromFile().

What to change

Implement Utils.yield() as an empty function. Also, remove the hack looking for the fallback URL to be read, check FilterStorage.firstRun instead.

Change History (16)

comment:1 Changed 6 years ago by trev

  • Summary changed from Implement API changes from #117 and #153 in Chrome to Implement API changes from #117 and #153 in Chrome and libadblockplus

comment:2 Changed 6 years ago by greiner

  • Review URL(s) modified (diff)

Added empty Utils.yield implementation (also see #191)
https://hg.adblockplus.org/adblockpluschrome/rev/516c7018cc9c

comment:3 Changed 6 years ago by trev

I am inclined to back out the change above because it really doesn't solve anything - it merely makes it look like things are working (see #191 which was resolved as "fixed"). In order for the Chrome (and libadblockplus) code to work correctly given the recent changes some more work needs to be done. Until then we should not update the adblockplus subrepository there.

comment:4 Changed 6 years ago by trev

  • Blocking 204 added

comment:5 Changed 6 years ago by sebastian

Please remove the workaround added by http://codereview.adblockplus.org/5118635873927168/ when this is fixed and the adblockplus subrepo is updated within the adblockpluschrome repository.

comment:6 Changed 6 years ago by trev

  • Owner set to trev
  • Status changed from new to assigned

comment:7 Changed 6 years ago by trev

  • Description modified (diff)

comment:8 Changed 6 years ago by trev

  • Review URL(s) modified (diff)

comment:9 Changed 6 years ago by trev

  • Blocked By 117, 153, 192 added
  • Summary changed from Implement API changes from #117 and #153 in Chrome and libadblockplus to Implement API changes from #117, #153, #192 in Chrome and libadblockplus

comment:10 Changed 6 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from assigned to reviewing

comment:12 Changed 6 years ago by trev

  • Review URL(s) modified (diff)

comment:13 Changed 6 years ago by trev

comment:14 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:15 Changed 5 years ago by trev

Updated libadblockplus-binaries repository as well: https://hg.adblockplus.org/libadblockplus-binaries/rev/7b68c61243c5

comment:16 Changed 5 years ago by trev

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
Note: See TracTickets for help on using tickets.