Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1897 closed change (fixed)

Compress auto-generated images with pngout

Reported by: sebastian Assignee: sebastian
Priority: P4 Milestone:
Module: Automation Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/4663693082099712

Description (last modified by sebastian)

Background

pngout is known to be the most efficient PNG optimizer, reducing file size of PNG files. We are used to run pngout before adding PNG files to our repositories. But some icons for Adblock Plus for Chrome/Opera/Safari are auto-generated, and therefore aren't currently optimized by pngout. However, we have quite a few auto-generated icons, which add up in file size.

What to change

Integrate pngout into the build process in order to optimize auto-generated images.

Hints for testers

Make sure that the toolbar icons on Safari are still rendered as before. Also check the icon animation on Chrome, Opera and Safari, which can be tested as described in #1965.

Change History (4)

comment:1 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by sebastian

  • Description modified (diff)

comment:3 Changed 5 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 5 years ago by sebastian

  • Description modified (diff)
Note: See TracTickets for help on using tickets.