Opened 6 years ago

Closed 2 years ago

#190 closed defect (rejected)

Adblock Plus toolbar icon disappearing

Reported by: Ede_123 Assignee:
Priority: P4 Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description

from mercurial log I see that there were various changes regarding the toolbar icon in Adblock 2.4.1. I'm afraid however that one of these changes introduced a regression, possibly related to how restartless extensions add themselves to the toolbars. If you have installed certain restartless extensions, the toolbar icon of Adblock Plus just vanishes from the toolbar (and can be rediscovered in the toolbox of the customized dialog).

Here are steps to reproduce the bug with DownThemAll! 3.0 Beta 5 which I tested on a clean profile:

  • Install Adblock Plus 2.4.1
  • ABP positions its icon automatically as the rightmost item of the default toolbar (besides the home button)
  • Install DownThemAll! 3.0 Beta 5 from the link above
  • Position the DownThemAll! "Manager" icon to the left of the ABP icon
  • Open a new window (CTRL+N) ---> the DownThemAll! icon is still there, but the ABP icon is gone
  • Close both windows and restart Firefox ---> the ABP is gone for good and also doesn't reappear

The steps above were performed using Firefox 27.0 on Windows 7 x64.

P.S.: Original report was here; similar forum thread here.

Change History (5)

comment:1 Changed 6 years ago by philll

  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed 5 years ago by philll

falsely spam-blocked comment by avada:
It was happenning before but stopped happening. I didn't see any reason to prompt it. I used 2.6.1.3820 for a long while and the button appeard albeit with a delay after startup.
Now I upgraded to Adblock Plus 2.6.3.3836 and the button started disappearing again. This time what I notice is that it disappears when I restart, but not on exit/start.

Restarting by default can be initiated from the addon manager when one disables/enables an addon, but there are also addons that can also initiate it.

It's highly annoying so I downgraded ABP. I usa Pale Moon 24.x (It's FF24 for the most part) It doesn't happen if I install ABP in a test account.

comment:3 Changed 5 years ago by philll

  • Platform set to Firefox

comment:4 Changed 5 years ago by trev

  • Cc trev added
  • Priority changed from P3 to P4

Reducing priority since that issue only seems to affect outdated Firefox versions (pre-Australis) and extension conflicts like this aren't exactly unexpected given how toolbar customization was implemented before Australis.

comment:5 Changed 2 years ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.

Note: See TracTickets for help on using tickets.