Opened 6 years ago

Closed 13 months ago

#1951 closed change (rejected)

new notification trigger mechanism based on ad counter

Reported by: annlee@… Assignee:
Priority: Unknown Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: sebastian, wspee Blocked By:
Blocking: Platform: Unknown
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by annlee@…)


There are many relevant messages which could be shown when the ad counter passes a certain number threshold, for example:

You've blocked 50,000 ads! If you're happy with this, please rate us.
You've blocked 50,000 ads! Help a friend do the same.
You've blocked 50,000 ads! Want to block more than just ads? Check out extra blocking features on our Options page.

See diagrams for more details

However, there are currently only trigger mechanisms based on extension version, application, platform. Therefore, this is a request for a new trigger mechanism based on an ad counter minimum threshold / number.

The important thing is that the number in the notification message matches the ad counter number that the user sees in the Bubble UI, therefore, using filter hits is less desirable since there can be discrepancies between filter hits and ad counter

What to change

Create a new notification mechanism that will trigger a notification message when the ad counter number,
as displayed in the bubble UI, is at or between a specified range of numbers, for example...

between 10,000 and 49,999
between 50,000-99,999
more than 100,000

Attachments (1)

ticket - ad counter trigger (1).png (128.2 KB) - added by annlee@… 5 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 6 years ago by annlee@…

  • Description modified (diff)

comment:2 Changed 6 years ago by annlee@…

  • Description modified (diff)

comment:3 Changed 5 years ago by annlee@…

  • Verified working unset

Changed 5 years ago by annlee@…

comment:4 Changed 5 years ago by annlee@…

  • Blocking 2162 added
  • Description modified (diff)

comment:5 Changed 5 years ago by fhd

  • Blocking 2162 removed

Not really blocked by #2162 technically.

comment:6 Changed 3 years ago by jeen

  • Cc sebastian@… added; annlee@… removed
  • Tester set to Unknown

comment:7 Changed 3 years ago by jeen

@sebastian I would like to resurrect this ticket as part of the cross-promotional initiative ( We are aiming for the messaging to be rolled out in September.

comment:8 Changed 3 years ago by sebastian

  • Cc sebastian wspee added; sebastian@… removed

As discussed in the meeting, our resources here are limited. So we won't be able to implement a bunch of changes to the notification system. But if it is established that this is the most useful thing we could do, we could potentially move forward with this single change. Though it might make sense to first finalize/update the spec, before moving forward with the implementation.

comment:9 Changed 3 years ago by jeen

@sebastian to keep resources and effort minimal, we would only want to implement a trigger based on the ad count - the number of ads at which the notification is triggered should be adjustable. I don't personally see the spec as something that should block this from moving forward since this is a new trigger? But do correct me if I am wrong.

comment:10 Changed 13 months ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.