Opened 5 years ago

Closed 4 years ago

#1954 closed change (rejected)

Fetch some ABP AMO data periodically and save it to the file

Reported by: saroyanm Assignee:
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: trev, simona, sebastian Blocked By:
Blocking: #1880, #1882 Platform: Unknown
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by saroyanm)

Background

As mentioned in #1880 we would like to show rating on Firefox landing page, but for that we need periodically download AMO data and save to our server.

What to change

Run script every week that will fetch AMO data and save "rating" and "reviews" tags into the XML file on our server that runs anwiki, the file should be accessible from anwiki abp_output plugin.

Change History (7)

comment:1 Changed 5 years ago by saroyanm

  • Blocking 1882 added

comment:2 Changed 5 years ago by saroyanm

  • Description modified (diff)

comment:3 Changed 5 years ago by sebastian

  • Component changed from Infrastructure to Sitescripts

comment:4 Changed 5 years ago by sebastian

  • Priority changed from Unknown to P3
  • Ready set

comment:5 Changed 4 years ago by sebastian

  • Cc sebastian added
  • Ready unset
  • Tester set to Unknown
  • Verified working unset

I guess, since we don't use Anwiki anymore, it probably makes more sense (if this feature is still desired) to implement it similar to how we fetch and show supported browser versions now, rather than having a separate cron job fetch those data.

comment:6 Changed 4 years ago by saroyanm

I think this issue was created a long time ago and while we are planing in future change the hompage and probably re-implement it I think it's better to close the issue for now, I think it doesn't worth the effort.
Also using fetching browser version is throwing exception from time to time:
https://issues.adblockplus.org/ticket/3986
https://issues.adblockplus.org/ticket/3773

I'm not sure if it make sense to rely on existing script that fetch the data and introduce additional potential exceptions.

comment:7 Changed 4 years ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

Fetching browser versions queries update servers which aren't meant to produce visible errors - if something fails the browsers will simply retry. AMO's API on the other hand is fairly reliable, we used to query it and there were only occasional errors, never something that persisted over days.

Whether doing this is worth the effort is another thing of course, with our CMS it would be fairly simple. We definitely don't need anything in sitescripts however, so this issue can be resolved - #1882 will suffice.

Note: See TracTickets for help on using tickets.