Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#196 closed defect (fixed)

2.5.1.3785 doesn't automatically add filter lists after installing

Reported by: arthur Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.6-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: greiner Blocked By:
Blocking: #153, #174 Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6242239667765248/
http://codereview.adblockplus.org/6304089612746752

Description

Environment

  • Windows 8.1 Pro x64
  • Firefox 28.0
  • Adblock Plus dev build 2.5.1.3785
  • New Firefox browser profile

How to reproduce

  1. Create a new browser profile
  2. Install the latest dev build

Observed behaviour

Adblock Plus doesn't automatically add a suitable filter list.

Expected behaviour

It should add a suitable filter list automatically.

Change History (8)

comment:1 Changed 6 years ago by trev

  • Blocking 174 added
  • Cc greiner added
  • in_progress changed from 0 to 1
  • Owner set to trev
  • Ready set
  • Status changed from new to assigned

Confirming, this is a regression from #174. In the Error Console I see:

ActiveFilter is not defined.

This is pointing to lib/antiadblockInit.js.

comment:2 Changed 6 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from assigned to reviewing

comment:3 Changed 6 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 6 years ago by trev

  • Milestone Adblock-Plus-for-Firefox-next deleted
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening, this doesn't seem to be completely fixed.

comment:5 Changed 6 years ago by trev

  • Blocking 153 added
  • Status changed from reopened to assigned

Apparently, there is also a bug here introduced by #153.

comment:6 Changed 6 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from assigned to reviewing

comment:7 Changed 6 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 6 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
Note: See TracTickets for help on using tickets.