Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#1984 closed change (fixed)

Do not use VBScript in installer build tools

Reported by: oleksandr Assignee: oleksandr
Priority: P4 Milestone: Adblock-Plus-for-Internet-Explorer-1.5
Module: Adblock-Plus-for-Internet-Explorer Keywords: goodfirstbug installer
Cc: oleksandr Blocked By:
Blocking: #1184 Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4565805475823616/

Description

Background

We currently use installer\emb.vbs to embed transforms when building the installer. It is written in VBScript, and we usually use Python for tasks like this.

What to change

Rewrite emb.vbs in Python.

Change History (6)

comment:1 Changed 5 years ago by greiner

  • Keywords goodfirstbug added; goodfrstbug removed

comment:2 Changed 5 years ago by oleksandr

  • Blocking 1184 added
  • Keywords installer added

comment:3 Changed 5 years ago by oleksandr

  • Owner set to oleksandr
  • Review URL(s) modified (diff)
  • Verified working unset

comment:4 Changed 5 years ago by oleksandr

  • Status changed from new to reviewing

comment:5 Changed 4 years ago by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 4 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.5
Note: See TracTickets for help on using tickets.