Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1985 closed change (fixed)

Replace __proto__ with Object.create() and Object.getPrototypeOf()

Reported by: sebastian Assignee: sebastian
Priority: P4 Milestone: Adblock-Plus-1.8.11-for-Chrome-Opera-Safari
Module: Platform Keywords: goodfirstbug
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/5721433737003008

Description

Background

The __proto__ property isn't officially supported before ES6. Also using it impairs the performance. Therefore we already replaced the __proto__ with Object.create() in the core code and Firefox extension (#656). However, a lot of code for Chrome, Opera and Safari is still using __proto__.

What to change

Use Object.create() and Object.getPrototypeOf() instead the __proto__ property.

Hints for tester

Well, this change effect pretty much all of our code. ;)

Change History (3)

comment:1 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.