Opened 5 years ago

Closed 5 years ago

#1992 closed defect (fixed)

createNightlies.py incorrectly determines repository name if repository path ends with a slash

Reported by: trev Assignee: trev
Priority: P1 Milestone:
Module: Infrastructure Keywords:
Cc: fhd Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/6304204159188992

Description (last modified by trev)

How to reproduce

  1. Configure the Android repository with a trailing slash:
    abpandroid_repository=/foo/bar/adblockplusandroid/
    abpandroid_type=android
    abpandroid_name=Adblock Plus for Android
    abpandroid_downloadPage=/en/android
    
  2. Run python -m sitescripts.extensions.bin.createNightlies. Alternatively, run the following Python code:
    import sitescripts.extensions.utils as utils
    for config in utils.Configuration.getRepositoryConfigurations():
      print [config.repository, config.basename]
    

Observed behaviour

Android builds are placed into the development builds root directory. The Python code prints (among other things):

['/foo/bar/adblockplusandroid', '']

This only affects repositories where the repository name cannot be determined from metadata and has to be guessed from repository path.

Expected behaviour

Android builds should be placed in the adblockplusandroid subdirectory. The Python code should print:

['/foo/bar/adblockplusandroid', 'adblockplusandroid']

Change History (3)

comment:1 Changed 5 years ago by trev

  • Description modified (diff)

comment:2 Changed 5 years ago by trev

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.