Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1995 closed change (rejected)

Add $recursive filter option to allow filter to apply for all child frames

Reported by: kzar Assignee:
Priority: Unknown Milestone:
Module: Core Keywords:
Cc: arthur, trev, sebastian Blocked By:
Blocking: Platform: Unknown
Ready: no Confidential: no
Tester: Verified working:
Review URL(s):

Description

Background

We need a way to have a filter for a page apply to all it's child frames. This can allow us to prevent the circumvention of filters by nesting adverts within a frame of a different domain.

What to change

Add the new $recursive filter option to the core filter code. When used a filter should match pages contained within frames based on both the domain of the page and the domain of all parent frames recursively.

This will be especially useful for whitelisting filters but presumably others as well.

Change History (3)

comment:1 Changed 5 years ago by sebastian

  • Cc arthur sebastian added; arthur@… removed

Filters are generally recursive, e.g. @@||example.com whitelists all URLs with the domain "example.com" as well as any third-party resource loaded as part of a page or frame hosted on "example.com".

So I suppose that we are only talking about the new filters to disable generic filters here. I think those filters should be recursive by default (or mandatory), to match the behavior of exception rules.

comment:2 Changed 5 years ago by kzar

  • Resolution set to rejected
  • Status changed from new to closed

comment:3 Changed 5 years ago by kzar

The decision in IRC was that the $generichide and $genericblock options should always apply recursively as with the other whitelisting rules making this extra option redundant.

Note: See TracTickets for help on using tickets.