Opened 4 years ago

Last modified 3 years ago

#2005 reviewing change

Refactor working with strings in InputBuffer and OutputBuffer

Reported by: sergz Assignee: sergz
Priority: P4 Milestone:
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By:
Blocking: Platform: Internet Explorer
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4882650246414336

Description

Background

It was discussed in the codereview http://codereview.adblockplus.org/4806567450902528/ that we should not bother the client of these buffer classes with the calls of string conversion functions like ToUtf16Strings.

What to change

We have not reached the consensus of how it should be. Let's discuss the major points here, not in the code review.

Change History (3)

comment:1 Changed 4 years ago by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

However, I've created a proposal of it. We always transfer the string as UTF-8 but the API provides the functions which work with UTF-16 (stored in std::wstring). So, the client of the buffer classes does not have to care about the conversions. Each communication part can safely use either std::string or std::wstring.

comment:2 Changed 4 years ago by trev

  • Owner set to sergz

comment:3 Changed 3 years ago by eric@…

  • Platform changed from Unknown to Internet Explorer
  • Tester set to Unknown
  • Verified working unset
Note: See TracTickets for help on using tickets.