Opened 5 years ago

Closed 5 years ago

#2008 closed defect (fixed)

Texts are missing in the UI if language code doesn't have a region

Reported by: maf654321 Assignee: sebastian
Priority: P2 Milestone: Adblock-Plus-1.8.11-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: sebastian, mapx Blocked By:
Blocking: Platform: Safari
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/4793439480709120

Description (last modified by mapx)

Environment

Mac OS X 10.10.2
Adblock Plus 1.8.10.1353

How to reproduce

Screenshot displaying the bug in effect is attached.

As I posted in adblockplus.org/forum/viewtopic.php?f=18&t=28206?

  1. Change primary language in Mac OS X to Gaelic, with English being the second language.
  2. Launch Safari and open the bubble UI by clicking the ABP icon
  3. Click Options

http://i.imgur.com/boZkUec.png

This group of settings consistently reproduces this bug for me, but I suspect other untranslated primary languages might also have a similar effect.

Observed behaviour

Both the dropdown, bubble UI and the options page are missing content. The dropdown is missing words, and the options page is almost blank, with only a few clickable boxes and a logo left. As well, if there is blocking lists already activated, the functionality is still somewhat broken, failing on Youtube.com at least.

http://i.imgur.com/EKXAlBu.png
http://i.imgur.com/cWvJErU.png

Expected behaviour

The Dropdown menu and Options page should be populated and usable.

Attachments (3)

boZkUec.png (210.6 KB) - added by maf654321 5 years ago.
Language Settings
cWvJErU.png (183.9 KB) - added by maf654321 5 years ago.
Options page
EKXAlBu.png (418.9 KB) - added by maf654321 5 years ago.
Dropdown Bubble UI

Download all attachments as: .zip

Change History (8)

Changed 5 years ago by maf654321

Language Settings

Changed 5 years ago by maf654321

Options page

Changed 5 years ago by maf654321

Dropdown Bubble UI

comment:1 Changed 5 years ago by mapx

  • Cc sebastian mapx added
  • Component changed from Unknown to Platform
  • Description modified (diff)
  • Owner set to sebastian

comment:2 Changed 5 years ago by mapx

(I didn't assign ... to sebastian ... how was this possible :O )

comment:3 Changed 5 years ago by sebastian

  • Priority changed from Unknown to P2
  • Ready set
  • Summary changed from Blank Toolbar Dropdown UI and Settings Page to Texts are missing in the UI if language code doesn't have a region

This regression were introduces by #1666. The change there assumes the region part of the language code to always be present, resulting in an error and breaking the UI if it isn't.

comment:4 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-1.8.11-for-Chrome-Opera-Safari
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.