Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2010 closed change (fixed)

Replace "for each" loops with "for of" loops (Firefox)

Reported by: tschuster Assignee: tschuster
Priority: P4 Milestone: Adblock-Plus-2.6.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: #312 Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

​http://codereview.adblockplus.org/6519778499887104/

Description (last modified by trev)

Background

Using for each is now deprecated and shows a warning in current Firefox nightlies. We are still using it in some UI code. Related: #2013.

What to change

Replace all usage of for each loops in the chrome/content/ui directory by for .. of loops.

Change History (9)

comment:1 Changed 5 years ago by mapx

  • Component changed from Unknown to Adblock-Plus-for-Firefox
  • Owner set to trev
  • Platform changed from Unknown to Firefox/Firefox Mobile

comment:2 Changed 5 years ago by trev

  • Description modified (diff)
  • Keywords goodfirstbug added
  • Owner trev deleted
  • Priority changed from Unknown to P4
  • Ready set

Please never assign issues to people other than yourself.

comment:3 Changed 5 years ago by trev

  • Summary changed from Remove some uses of "for each" with "for of" to Replace "for each" loops with "for of" loops (Firefox)

comment:4 Changed 5 years ago by trev

  • Description modified (diff)

comment:5 Changed 5 years ago by trev

  • Description modified (diff)

comment:6 Changed 5 years ago by tschuster

  • Keywords goodfirstbug removed
  • Owner set to tschuster
  • Review URL(s) modified (diff)

comment:7 Changed 5 years ago by tschuster

Oh sorry for not immediately assigning this properly. I also didn't update all for each uses chrome/content/ui so I am going to update my patch to do that.

comment:8 Changed 5 years ago by tschuster

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from new to closed

Fixed: ​https://hg.adblockplus.org/adblockplus/rev/d9b4059a9f8f

comment:9 Changed 5 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Note: See TracTickets for help on using tickets.