Opened 5 years ago

Closed 5 years ago

Last modified 9 months ago

#2014 closed change (rejected)

Adblock Plus Options should show version numbers of lists

Reported by: jidanni Assignee:
Priority: Unknown Milestone:
Module: User-Interface Keywords:
Cc: greiner, sven, sebastian Blocked By:
Blocking: Platform: Chrome
Ready: no Confidential: no
Tester: Verified working:
Review URL(s):

Description

On chrome-extension://cfhdojbkjhnklbpkdaibdccddilifddb/options.html
be sure to show each list's version number.

That is the ONLY sure way the user can see at a glance if
clicking "Update now" really read the CONTENT of the lists.

Change History (6)

comment:1 Changed 5 years ago by sebastian

  • Cc greiner sven sebastian added
  • Component changed from Unknown to User-Interface

Put greiner and sven into CC for triaging.

comment:2 Changed 5 years ago by greiner

  • Resolution set to rejected
  • Status changed from new to closed

There already is an indicator in the options page which is only updated after a filter list was successfully added: the last updated date next to the filter list name. In case the download fails or a different problems occurs when adding the filter list, you will see red text in its place informing you about it.

FYI: The version number is an optional meta information that a filter list can include. That means that the version might not be available for some filter lists, plus, it would only indicate when the list was last modified but not when its content was last read.

comment:3 follow-up: Changed 5 years ago by jidanni

OK. However TaperMonkey does this on its Installed UserScripts panel.

On https://adblockplus.org/en/filters please be sure to say that Checksum and Version comments are completely optional.

Also give a link to a sample working filter file. One looks around and only finds Easylist which probably isn't a good one as a tutorial example.

Anyway all the filters I have ever wrote don't really work, e.g.,
http://m.jidanni.org/adblockplus/jidanni.txt
so one assumes they just don't get read in correctly. That's why I want ABP to show some proof that it indeed has registered its contents somewhere in its brain, despite not seeing any error message.

comment:4 in reply to: ↑ 3 Changed 5 years ago by greiner

Replying to jidanni:

OK. However TaperMonkey does this on its Installed UserScripts panel.

They might have a valid use-case for this.

On https://adblockplus.org/en/filters please be sure to say that Checksum and Version comments are completely optional.

Also give a link to a sample working filter file. One looks around and only finds Easylist which probably isn't a good one as a tutorial example.

You're right, that would be a valid issue. We should mention that the only requirement is to have a text of the form /\[Adblock(?:\s*Plus\s*([\d\.]+)?)?\]/i at the beginning of the filter list - everything else is optional. Here's a valid Hello World-type of filter list that blocks any resource with either "hello" or "world" in it:

[Adblock]
hello
world

Anyway all the filters I have ever wrote don't really work, e.g.,
http://m.jidanni.org/adblockplus/jidanni.txt
so one assumes they just don't get read in correctly. That's why I want ABP to show some proof that it indeed has registered its contents somewhere in its brain, despite not seeing any error message.

For filter support I'd recommend reaching out to the filter list maintainers (either in their forum or in ours).

Generally, it's more common to use || instead of http:// at the beginning of a filter so you may want to try that first.

comment:5 Changed 5 years ago by jidanni

OK. Do mention those two forums there. Currently all one finds is

$ lynx -dump https://adblockplus.org/en/filters | grep -i forum
     * [43]Forum
  43. https://adblockplus.org/forum/

comment:6 Changed 9 months ago by Thanos

spam

Last edited 9 months ago by greiner (previous) (diff)
Note: See TracTickets for help on using tickets.