Opened 4 years ago

Closed 4 years ago

#2034 closed change (fixed)

MAX_HANDLER_BEHAVIOR_CHANGED_CALLS_PER_10_MINUTES isn't respected

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.9-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6615790883176448

Description

Background

The chrome.webRequest.MAX_HANDLER_BEHAVIOR_CHANGED_CALLS_PER_10_MINUTES constant isn't respected. Hence chrome.webRequst.behaviorChanged() is potentially called more than 20 times within 10 minutes, mitigation the effect of Chrome's in-memory cache. This also leads to Chrome notifying the user that Adblock Plus slows down Chrome.

What to change

Make sure that chrome.webRequst.behaviorChanged() isn't called more often than configured by chrome.webRequest.MAX_HANDLER_BEHAVIOR_CHANGED_CALLS_PER_10_MINUTES. Delay calls when the quota is exceeded.

Hints for testers

The first 20 filter changes should still show immediate effect, even when those filters block requests that are effect by Chrome's in-memory cache. When quota exceeded, filter changes might not be visible for cached request. But latest after 10 minutes the cache should be automatically flushed. Also make sure that performing a lot of filter changes in a short period doesn't bring up a warning (under chrome://extensions) about Adblock Plus slowing down Chrome anymore.

Change History (3)

comment:1 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)

comment:2 Changed 4 years ago by sebastian

  • Status changed from new to reviewing
  • Verified working unset

comment:3 Changed 4 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.