Opened 5 years ago

Closed 5 years ago

#2036 closed change (rejected)

[adblockplus.org Anwiki to CMS migration] Detect user's language and browser for landing page

Reported by: kzar Assignee:
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: sebastian, trev, saroyanm Blocked By:
Blocking: #2035 Platform: Unknown
Ready: no Confidential: no
Tester: Verified working:
Review URL(s):

Description

Background

When visiting https://adblockplus.org the user's locale and browser is detected. An appropriate landing page is then displayed advising them to install the correct browser in the correct language.

Before we can complete the migration away from Anwiki the new version of the website in the wwwnew repository also needs to do the same.

What to change

So far the user's browser and locale is not detected, instead the default values Firefox and English are always used respectively. Change this so that the language and browser detection works as it does on https://adblockplus.org . Fix any related redirections that are currently broken / hardcoded / non-existing in wwwnew.

Change History (4)

comment:1 Changed 5 years ago by saroyanm

  • Cc sebastian added

@Sebastian shouldn't this be a Sitescript ticket rather than Websites ?

comment:2 follow-up: Changed 5 years ago by sebastian

It depends how this is implemented. If nginx is supposed to do a redirect (or something) dependent on locale and user agent, it would be Infrastructure. If we would use a redirector script, it would be Sitescripts. If we do it on the client-side, it would be Websites.

So yes, this issue isn't specified enough to identify the corresponding module, or even to implement it.

comment:3 in reply to: ↑ 2 Changed 5 years ago by saroyanm

  • Cc trev saroyanm added

Replying to sebastian:

If we do it on the client-side, it would be Websites.

We can modify the "#content" div dynamically on client side, I guess that's possible the only problem I see here is accessibility, while I'm not sure if somebody is going to visit our page with disabled javascript, maybe we can go with client side implementation ?

But I still fan of accessibility even if in this case it's not mandatory.

@Wladimir do you have an idea how we would like to do redirect and implement UA detection ?

comment:4 Changed 5 years ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

This functionality isn't implemented in Anwiki but rather in the webserver configuration (see our Puppet configuration for the test Anwiki install). It will work the same way with the new CMS as well. The only concern here is making testing easier as the test server doesn't include that functionality.

Anyway, rejected - this will be part of the Puppet config for the new web server, nothing to do in the Websites component.

Note: See TracTickets for help on using tickets.