Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#204 closed change (fixed)

Replacing "ChinaList" with "EasyList China" in Chrome, Opera, Safari and Android

Reported by: jobp Assignee:
Priority: P3 Milestone: Adblock-Plus-for-Android-1.3
Module: Adblock-Plus-for-Android Keywords:
Cc: trev, rjeschke Blocked By: #189
Blocking: Platform:
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by philll)

Background

Last week we changed the default list for Chinese users from "ChinaList" to "EasyList China". However, this is not updated in the extension yet. Currently, it is misleading, because people opting in to enabling "ChinaList" will end up with "EasyList China".

What to change

According to Arthur, this change is already in the devbuild of Firefox. However, this change needs to be implemented for the other browsers / platforms: Chrome, Opera, Safari and Android.

Change History (10)

comment:1 Changed 6 years ago by trev

  • Blocked By 189 added
  • Component changed from Unknown to Libadblockplus
  • Milestone Adblock-Plus-for-Internet-Explorer-next deleted
  • Priority changed from Unknown to P3

This requires updating dependency on Adblock Plus/Firefox in libadblockplus which is currently blocked on #189.

comment:2 Changed 6 years ago by trev

  • Cc trev added

comment:3 Changed 6 years ago by philll

#189 was fixed, so we could proceed here.

Last edited 6 years ago by trev (previous) (diff)

comment:4 Changed 6 years ago by trev

  • Cc rjeschke added
  • Component changed from Libadblockplus to Adblock-Plus-for-Android

Actually, this is already resolved in libadblockplus and I also updated libadblockplus-binaries. ABP/Android merely needs to include the current version of libadblockplus-binaries. René, is that something that's on your radar?

comment:5 Changed 6 years ago by rjeschke

Now it is, will update this today.

comment:6 Changed 6 years ago by philll

  • Resolution set to fixed
  • Status changed from new to closed

Seems to be fixed.

comment:7 Changed 6 years ago by philll

  • Resolution fixed deleted
  • Status changed from closed to reopened

Hm, one might argue that fixing it in libadblockplus isn't sufficient to get the effect everywhere. Not yet in IE.

comment:8 Changed 6 years ago by trev

  • Resolution set to fixed
  • Status changed from reopened to closed

Please file one more issue for IE - the dependency on libadblockplus needs to be updated there as well.

comment:9 Changed 6 years ago by philll

  • Description modified (diff)
  • Summary changed from Replacing "ChinaList" with "EasyList China" in Chrome, Opera, Safari, IE and Android to Replacing "ChinaList" with "EasyList China" in Chrome, Opera, Safari and Android

See #466 for IE.

comment:10 Changed 6 years ago by trev

  • Milestone set to Adblock-Plus-for-Android-next
Note: See TracTickets for help on using tickets.