Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2041 closed defect (fixed)

Filter Preferences: Findbar not fully functional in Firefox 36

Reported by: mapx Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.6.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: greiner, trev Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/4964592316841984/

Description (last modified by trev)

Environment

FF 36 (Windows XP)
ABP 2.6.7.3897

How to reproduce

  • Open Filter Preferences window.
  • Press Ctrl+F to search for a filter, type "asdf123456789".

Expected result: the filter isn't found, so the input field should turn red and there should be a corresponding message.

Actual result: no visual feedback if filter isn't found. Also errors in Error Console:

NS_ERROR_FAILURE: Failure arg 0 [nsIEventListenerService.addSystemEventListener] findbar.xml:266:0

NS_ERROR_FAILURE: Failure arg 0 [nsIEventListenerService.removeSystemEventListener] findbar.xml:255:0

Background

The exception comes from the browser's findbar widget. It calls nsIEventListenerService.addSystemEventListener() with this._browser as first parameter. In our case its value isn't a DOM element however but a fake browser object, hence the exception. Originally it was calling this._browser.addEventListener() which we emulate. The only impact appears to be missing feedback if the search failed.

What to change

Instead of using a separate object, inject the properties of the fake browser into the filtersTree element. As this one is a real DOM element, nsIEventListenerService.addSystemEventListener() will work on it.

Change History (8)

comment:1 Changed 5 years ago by mapx

  • Cc greiner trev added

comment:2 Changed 5 years ago by trev

  • Description modified (diff)
  • Priority changed from Unknown to P1
  • Ready set

comment:3 Changed 5 years ago by trev

  • Description modified (diff)

comment:4 Changed 5 years ago by trev

  • Owner set to trev

comment:5 Changed 5 years ago by trev

  • Summary changed from FF 36, errors in console to Filter Preferences: Findbar not fully functional in Firefox 36

comment:6 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 5 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 5 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Note: See TracTickets for help on using tickets.