Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2047 closed change (fixed)

Update QUnit to version 1.17.1

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-2.6.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: #2040, #2048 Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/5721576209121280/

Description (last modified by sebastian)

Background

Currently Adblock Plus uses QUnit 1.12 to run its tests. This is a very old version however. Also start() and stop() have been deprecated. But the new method to write asynchronous tests isn't available in QUnit 1.12. So we should update QUnit before writing any more asynchronous test code (like for #2040), to reduce the amount of code that needs to be adapted later (by #2048).

What to change

Update QUnit as used to test Adblock Plus to version 1.17.1.

Hints for testers

The test suite isn't part of the build. So there is nothing to test here.

Change History (8)

comment:1 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by sebastian

  • Blocking 2048 added

comment:3 Changed 5 years ago by sebastian

  • Description modified (diff)

comment:4 Changed 5 years ago by sebastian

  • Description modified (diff)

comment:5 Changed 5 years ago by sebastian

  • Description modified (diff)

comment:6 Changed 5 years ago by trev

  • Component changed from Core to Adblock-Plus-for-Firefox
  • Platform changed from Unknown to Firefox/Firefox Mobile
  • Review URL(s) modified (diff)

comment:7 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 5 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Note: See TracTickets for help on using tickets.