Opened 5 years ago

Closed 2 years ago

#2048 closed change (rejected)

Make tests use async() instead of deprecated asyncTest() and start() functions

Reported by: sebastian Assignee:
Priority: P4 Milestone:
Module: Adblock-Plus-for-Firefox Keywords: goodfirstbug
Cc: trev Blocked By: #2047
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

Description (last modified by trev)

Background

QUnit's asyncTest() and start() functions have been deprecated (the former still being fine in setup and teardown). So once we updated to QUnit 1.17.1 (#2047), we should adapt asynchronous tests to use the new API instead.

What to change

Replace asyncTest() and start() with done = assert.async() and done() in all tests in the adblockplustests repository.

Hints for testers

The test suite isn't part of the build. So there is nothing to test here.

Change History (5)

comment:1 Changed 5 years ago by sebastian

  • Description modified (diff)
  • Summary changed from Make tests uses async() instead deprecated start()/stop() to Make tests uses async() instead asyncTest(), start() and stop()

comment:2 Changed 5 years ago by trev

  • Component changed from Core to Adblock-Plus-for-Firefox
  • Description modified (diff)
  • Platform changed from Unknown to Firefox/Firefox Mobile
  • Priority changed from Unknown to P4
  • Ready set
  • Summary changed from Make tests uses async() instead asyncTest(), start() and stop() to Make tests use async() instead of deprecated asyncTest() and start() functions

comment:3 Changed 5 years ago by trev

  • Keywords goodfirstbug added

comment:4 Changed 5 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

comment:5 Changed 2 years ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.

Note: See TracTickets for help on using tickets.