Opened 5 years ago

Closed 5 years ago

#2053 closed change (fixed)

Replace Adblock Plus logo on the first-run page

Reported by: trev Assignee: trev
Priority: Unknown Milestone:
Module: User-Interface Keywords:
Cc: greiner, sven Blocked By:
Blocking: #1533 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

​http://codereview.adblockplus.org/5767210236641280/

Description

Background

Subject of #1533 is replacing the ABP logo by the new one everywhere. So far, this didn't happen for the first-run page however, it still uses an old 100x99 image (custom size).

What to change

Use the 128x128 ABP logo (icons/abp-128.png in the adblockpluschrome repository), it's closest in size to the old one.

Attachments (2)

old.png​ (87.7 KB) - added by trev 5 years ago.
new.png​ (86.0 KB) - added by trev 5 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

Changed 5 years ago by trev

Changed 5 years ago by trev

comment:2 Changed 5 years ago by trev

  • Cc sven added

Here is what it looks like with the current changes:

Old New

The content has been moved down by a bunch of pixels due to the larger logo.

comment:3 Changed 5 years ago by sven

lgtm

comment:4 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/adblockplusui/rev/d1335219a5ac

Note: See TracTickets for help on using tickets.