Opened 6 years ago

Closed 5 years ago

Last modified 4 years ago

#206 closed change (fixed)

Add a pre-configurable option to disable the first run page in Firefox

Reported by: treed873 Assignee: fhd
Priority: P3 Milestone: Adblock-Plus-2.6.9-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords: growth, large-scale-deployments
Cc: smultron45@…, simona, sebastian Blocked By:
Blocking: #542, #2347 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6331143469137920/

Description (last modified by fhd)

Background

Is there a way to disable the first run tab from opening for new users in a domain? I have set up adblock plus to self install on a thin client system, where the C drive is static. Bottom line is, when a user logs in, they are basically a new user every time. Therefore they will receive the "Adblock Plus has been installed" page every time they log in.

What to change

Add a preference to skip the first run page.

Change History (27)

comment:1 Changed 6 years ago by mapx

  • Type changed from defect to change

comment:2 Changed 6 years ago by mapx

feature requested too by few chrome users

comment:3 Changed 6 years ago by mapx

  • Priority changed from Unknown to P3

comment:4 Changed 6 years ago by greiner

Currently, it is not implemented but we could introduce a setting for that which we'd check in the function that opens the first-run page and prevent it from being opened.

comment:5 Changed 6 years ago by treed873

That would be a welcomed addition.

As a temporary workaround/hack, I simply removed this section of code from ui.js:

function notifyUser()
    {
      let {addTab} = require("appSupport");
      if (addTab)
      {
        addTab(window, "chrome://adblockplus/content/ui/firstRun.html");
      }
      else
      {
        let dialogSource = '\
          <?xml-stylesheet href="chrome://global/skin/" type="text/css"?>\
          <dialog xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" onload="document.title=content.document.title" buttons="accept" width="500" height="600">\
            <iframe type="content-primary" flex="1" src="chrome://adblockplus/content/ui/firstRun.html"/>\
          </dialog>';
        Services.ww.openWindow(window,
                               "data:application/vnd.mozilla.xul+xml," + encodeURIComponent(dialogSource),
                               "_blank", "chrome,centerscreen,resizable,dialog=no", null);
      }

This seems to work well in our environment.

comment:6 Changed 6 years ago by philll

  • Component changed from Adblock-Plus-for-Firefox to Core
  • Description modified (diff)
  • Ready set
  • Summary changed from Firefox: disable First Run for corporate domain environment to Disable First Run for corporate domain environment

comment:7 Changed 6 years ago by Gingerbread Man

I simply removed this section of code from ui.js:

That requires either not updating Adblock Plus, or redoing the changes every time. You should be able to accomplish the same thing without modifying Adblock Plus by locking the extensions.adblockplus.currentVersion preference.
http://kb.mozillazine.org/Locking_preferences

extensions.adblockplus.currentVersion
Stores the last used Adblock Plus version, this will trigger actions that need to be done on upgrade or first install

comment:8 Changed 6 years ago by treed873

I have the Preferences locked in my mozilla.cfg file:

// disable application updates
pref("app.update.enabled", false)

It will still show the first run tab every time. There really isn't an option that I can see that will enable me to disable this.

comment:9 Changed 6 years ago by mapx

  • Cc smultron45@… added

comment:10 Changed 6 years ago by fhd

  • Component changed from Core to Adblock-Plus-for-Firefox

IMO this is a pretty platform-specific issue, so I'm changing the component for this to Firefox again.

I've filed #278 about implementing this in Chrome.

comment:11 Changed 6 years ago by Gingerbread Man

pref("app.update.enabled", false)

  1. That preference isn't locked.
  2. What does disabling Firefox updates have to do with this issue? I'm saying try adding the following to mozilla.cfg:
    lockPref("extensions.adblockplus.currentVersion", "2.5.1");
    

comment:12 Changed 6 years ago by treed873

Yes, I see what you mean about disabling Firefox updates, but I really don't see how disabling ABP from updating will fix this either. Because of my environment (see above), ABP sees every login as a new user, therefore it will always bring up the Welcome tab.

comment:13 Changed 5 years ago by sebastian

  • Blocked By 1487 added

comment:14 Changed 5 years ago by sebastian

  • Blocked By 1489 added; 1487 removed
  • Platform set to Unknown

comment:15 Changed 5 years ago by sebastian

  • Blocking 542 added
  • Description modified (diff)

comment:16 Changed 5 years ago by sebastian

  • Summary changed from Disable First Run for corporate domain environment to Add a pre-configurable option to disable the first run page in Firefox

comment:17 Changed 5 years ago by simona

  • Keywords growth added

comment:18 Changed 5 years ago by simona

  • Cc simona added

comment:19 Changed 5 years ago by simona

  • Keywords large-scale-deployments added

comment:20 Changed 5 years ago by fhd

I'll add a pref for this.

comment:21 Changed 5 years ago by fhd

  • Owner set to fhd

comment:22 Changed 5 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:23 Changed 5 years ago by fhd

  • Blocked By 1489 removed
  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:24 Changed 5 years ago by sebastian

  • Cc sebastian added

You added just a regular preference, not a pre-configurable one as specified in the issue description. The description is outdated anyway. And eventually what you did might be sufficient. But please update the description to reflect the actual change.

comment:25 Changed 5 years ago by fhd

  • Description modified (diff)

It is preconfigurable, that's also why I removed #1489 from Blocked by. There's a discussion, in #1489 among other places, about a mechanism for preconfiguring preferences while still allowing the user to change prefs, but that's a separate thing IMO.

But you're right, the description said it should be a pre-configurable option as implemented by #1489, which is not what happened. Changed it.

comment:26 Changed 4 years ago by fhd

  • Blocking 2347 added
Note: See TracTickets for help on using tickets.