Opened 4 years ago

Closed 4 years ago

#2063 closed change (fixed)

Make ext.webRequest use ABP instead Chrome request types

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.8.12-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: #2064 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/5192819564085248

Description

Background

Currently, ext.webRequest.onBeforeRequest uses Chrome's request types. However, in webrequest.js we convert them into into Adblock Plus request types. This could be simplified if we map elements directly to Adblock Plus requests tyes on Safari, and just convert the requests type in the implementation for Chrome.

What to change

Make ext.webRequest.onBeforeRequest use Adblock Plus request types (e.g. SUBDOCUMENT instead sub_frame and IMAGE instead image).

Hints for testers

This change effects request blocking, in particular filters limited to a given request type.

Change History (3)

comment:1 Changed 4 years ago by sebastian

  • Blocking 2064 added

comment:2 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 4 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.