Opened 4 years ago

Closed 4 years ago

#2066 closed change (fixed)

Get rid of non-standard __defineGetter__, __defineSetter__, and __lookupGetter__

Reported by: sebastian Assignee: sebastian
Priority: P4 Milestone: Adblock-Plus-1.8.12-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/5485735259930624

Description

Background

Some legacy code is still using __defineGetter__, __defineSetter__, and __lookupGetter__.
However, those methods are non-standard, and new code should use Object.defineProperty and Object.getOwnPropertyDescriptor instead.

What to change

Get rid of code using __defineGetter__, __defineSetter__, and __lookupGetter__. Use Object.definePoperty and Object.getOwnPropertyDescriptor instead where necessary.

Hints for testers

This change effects the logic setting and retrieving preferences.

Change History (2)

comment:1 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.