Opened 5 years ago

Closed 5 years ago

#2076 closed change (fixed)

"Block element" dialog should only suggest element hiding filters if there are no blocking filters

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.8.12-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By: #1853
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/5358312170192896

Description

Background

Currently, the "Block element" dialog suggests as many different filters as it can generate for the given element. However, generated element hiding filters often cause false positives. Moreover, when we already generated a blocking filter, additional element hiding filters for that element are usually unneeded.

What to change

Make the "Block element" dialog suggest element hiding filters, only if no blocking filters can be generated.

Change History (2)

comment:1 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.