Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#2080 closed change (fixed)

Remove duplicated code from clickHide_deactivate

Reported by: sebastian Assignee: sebastian
Priority: P4 Milestone: Adblock-Plus-1.8.12-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/6008293193416704

Description

Background

In order to fix #1610, we added an argument to clickHide_deactivate() to keep the overlays but removing the event listeners, when showing the "Block element" dialog. However, this is what clickHide_rulesPending() already does. But for some reason that function isn't used anymore.

What to change

Call clickHide_rulesPending() instead clickHide_deactivate(true) when showing the "Block Element" dialog. And remove the keepOverlays argument from clickHide_deactivate(). Also remove duplicated code from clickHide_deactivate(), calling clickHide_rulesPending() there instead.

Hints for testers

Make sure that "Block element" works as it did before, especially in the case when the dialog showed up, and you move the mouse across the page.

Change History (3)

comment:1 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.