Opened 5 years ago

Closed 4 years ago

#2100 closed defect (fixed)

"Block element" dialog moves out of visible area when attempt to drag it

Reported by: passbrains Assignee: greiner
Priority: P3 Milestone: Adblock-Plus-1.9-for-Chrome-Opera-Safari
Module: User-Interface Keywords:
Cc: sebastian, greiner Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5289539543236608/

Description (last modified by greiner)

Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ASA-44

Environment

Chrome, Opera and Safari

How to reproduce

  1. Go to any page, where "Block Element" is supported (i.e: HTTP(S) protocol + HTML content + not whitelisted)
  2. Click ABP button on toolbar
  3. Click "Block element" option
  4. Click any element on the page
  5. Drag the dialog out of the visible area

Observed behaviour

Add filter window disappears, it moves out of screen when attempt to drag it.

Expected behaviour

It shouldn't be possible to drag the "Block element" dialog out of the visible area.

What to change

In include.postload.js prevent frame from moving outside the viewport by checking the coordinates sent by the frame against window.innerWidth and window.innerHeight.

Attachments (3)

2315_1425489169_2015-03-04_1903.png (517.6 KB) - added by passbrains 5 years ago.
2315_1425489169_2015-03-04_1903_1.png (524.7 KB) - added by passbrains 5 years ago.
2315_1425489169_Screen_Recording.mov (4.4 MB) - added by passbrains 5 years ago.

Download all attachments as: .zip

Change History (8)

Changed 5 years ago by passbrains

Changed 5 years ago by passbrains

Changed 5 years ago by passbrains

comment:1 Changed 5 years ago by sebastian

  • Cc sebastian greiner added
  • Component changed from Unknown to User-Interface
  • Description modified (diff)
  • Owner set to greiner
  • Platform changed from Safari to Unknown

Reproduced. Putting greiner in CC for further triaging.

comment:2 Changed 5 years ago by sebastian

  • Summary changed from Add filter window moves out of screen when attempt to drag it to "Block element" dialog moves out of visible area when attempt to drag it

comment:3 Changed 5 years ago by greiner

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set

comment:4 Changed 5 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 4 years ago by greiner

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
  • Verified working unset
Note: See TracTickets for help on using tickets.