Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2101 closed change (fixed)

[adblockplus.org Anwiki to CMS migration] Don't duplicate generic interface strings for each interface

Reported by: trev Assignee: kzar
Priority: P4 Milestone:
Module: Websites Keywords:
Cc: Blocked By:
Blocking: #2035 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

http://codereview.adblockplus.org/5958799332474880/

Description

Background

Current implementation will add generic messages like "General notes" to the locale file for each interface. This is unnecessary duplication.

What to change

Move these strings into a shared locale file, e.g. interface.json.

Change History (4)

comment:1 Changed 5 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by kzar

  • Owner set to kzar

comment:3 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 5 years ago by Ross

  • Verified working set

Interface strings are no longer duplicated.

Tested by:
Running the convert script and checking the output. Output contains one version of the interface strings which are then referred to elsewhere with {{sX StringName }} as expected.

Note: See TracTickets for help on using tickets.