Opened on 03/09/2015 at 01:06:45 PM

Closed on 04/08/2015 at 02:04:40 PM

Last modified on 05/15/2015 at 04:31:46 AM

#2108 closed change (fixed)

Extra flag in the language selection

Reported by: trev Assignee: saroyanm
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: saroyanm Blocked By:
Blocking: #2035 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

Description (last modified by saroyanm)


Currently, some links (English, German) in the language selector have an extra flag on the right. This is because these links have a hreflang attribute now, but didn't in Anwiki.

What to change

Make sure that hreflang styling doesn't apply to the language selector. This should be fixed in our current styles for Anwiki first so that these don't get out of sync. These changes can then be imported into the repository automatically.

Attachments (0)

Change History (8)

comment:1 Changed on 03/10/2015 at 02:09:22 PM by saroyanm

  • Cc saroyanm added

comment:2 Changed on 04/08/2015 at 09:09:56 AM by saroyanm

  • Owner set to saroyanm
  • Verified working unset

comment:3 Changed on 04/08/2015 at 11:04:25 AM by saroyanm

I think it's wrong approach to apply the styling only to anwiki because we are using this styles for the links that are only available in English or the translation for current language is not available, so we are redirecting them to English version of the page (ex.: footer items-> Blog posts, Forum, Releases, Road-map):
So I'll suggest exclude the styling from the languages menu only.

comment:4 Changed on 04/08/2015 at 12:29:24 PM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 follow-up: Changed on 04/08/2015 at 12:33:17 PM by trev

  • Description modified (diff)

Looks like I messed up the "what to change" section here, fixed it now. Let me know whether you disagree with the suggested approach.

comment:6 in reply to: ↑ 5 Changed on 04/08/2015 at 12:46:10 PM by saroyanm

  • Description modified (diff)

Replying to trev:

Looks like I messed up the "what to change" section here, fixed it now. Let me know whether you disagree with the suggested approach.

Updated, after last discussion under the review.

comment:7 Changed on 04/08/2015 at 02:04:40 PM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed on 05/15/2015 at 04:31:46 AM by Ross

  • Verified working set


Tested on:

Tested with:

IE8.0.6001Windows XP
IE9.0.8112Windows 7
IE10.0.9200Windows 7
IE11.0.9600Windows 8.1
Chrome42.0.2311.135Windows 8.1
Opera29.0.1795.47Windows 8.1
Firefox37.0.2Windows 8.1
Safari7.0OSX 10.9
Chrome42.0.3211.111Android 4.4.2
Firefox Mobile29.0.1Android 4.4.2
Browser4.4.2-15Android 4.4.2

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
Note: See TracTickets for help on using tickets.