Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2110 closed change (fixed)

[adblockplus.org Anwiki to CMS migration] Not all links are added to the messages

Reported by: trev Assignee:
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: saroyanm Blocked By:
Blocking: #2035 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

Description

Background

The conversion script used for #1170 was supposed to merge links into strings, so $s12$ <a href="foo"> $s13$ would become $s12(foo)$. This happened very inconsistently however, e.g. in about.raw it is still $s5$ <a href="https://en.wikipedia.org/wiki/Adblock_Plus">$s6$</a>$s7(https://eyeo.com)$ rather than $s5(https://en.wikipedia.org/wiki/Adblock_Plus,https://eyeo.com)$.

What to change

Make sure links are merged into strings consistently rather than breaking up strings.

Change History (3)

comment:1 Changed 5 years ago by saroyanm

  • Cc saroyanm added

comment:2 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from new to closed

#2136 appears to have resolved this, with #2140 being the only remaining part.

comment:3 Changed 5 years ago by Ross

  • Verified working set

Implemented and working.

Tested by:
Running the website converter script as per the read me and checking the output for translatable links (such as on the AA pages).

Tested with:
www / r18024
sitescripts / r501
web.adblockplus.org / r68
website-converter / master / 105208883c4336a3788820fe9ab379cf639f8387

Note: See TracTickets for help on using tickets.