Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2112 closed change (fixed)

[CMS] Support inserting fixed text into strings

Reported by: trev Assignee: kzar
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: saroyanm Blocked By:
Blocking: #2035, #2339 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

http://codereview.adblockplus.org/5144941147717632/

Description (last modified by kzar)

Background

Currently there is an occasional patterns like {{s123 There are more than}} 20 {{s124 million users}} in our pages. The two strings s123 and s124 should really be one string but the number 20 is fixed and preventing these strings from being merged.

What to change

Support inserting fixed strings into a localizable string, e.g. as {{s123 There are more than <fix>20</fix> million users}}. The actual string to be translated should be There are more than {1} million users. - insertion points for fixed strings should be indicated by placeholders {1} and {2}.

Change History (11)

comment:1 Changed 5 years ago by trev

  • Blocking 2035 added
  • Cc 2035 removed

comment:2 Changed 5 years ago by saroyanm

  • Cc saroyanm added

comment:3 Changed 5 years ago by trev

  • Description modified (diff)

comment:4 Changed 5 years ago by trev

  • Description modified (diff)

comment:5 Changed 5 years ago by kzar

  • Owner set to kzar
  • Verified working unset

comment:6 Changed 5 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 5 years ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 5 years ago by trev

  • Blocking 2339 added

comment:9 Changed 5 years ago by kzar

  • Description modified (diff)

comment:11 Changed 5 years ago by Ross

  • Verified working set

Implemented and working.

Tested by:
Checking data in web.adblockplus.org (index.tmpl/json has a good example). Also running the website converter script as per the read me and checking the output.

Tested with:
www / r18024
sitescripts / r501
web.adblockplus.org / r68
website-converter / master / 105208883c4336a3788820fe9ab379cf639f8387

Note: See TracTickets for help on using tickets.