Opened 5 years ago

Closed 5 years ago

#2115 closed defect (fixed)

'Block element' is not issuing Add filters dialog box.

Reported by: passbrains Assignee: sebastian
Priority: P2 Milestone: Adblock-Plus-1.8.12-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: mapx, sebastian Blocked By:
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/5509249400569856

Description (last modified by Ross)

Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ACH-146

Environment

Windows + 8 64bit + Chrome + English
ABP version 1.8.11.1391

How to reproduce

  1. Open http://www.amazon.in/.
  2. Right-click on cart on top most right corner and choose 'Block element'.

Observed behaviour

Add filters dialog box is not opened.

Expected behaviour

Add filters dialog box is opened with suggested filters.

Related to #1868.

Attachments (1)

3766_1425984343_chromeArea.png (547.8 KB) - added by passbrains 5 years ago.

Download all attachments as: .zip

Change History (9)

Changed 5 years ago by passbrains

comment:1 Changed 5 years ago by passbrains

1 - 10 Mar 2015 14:36:17 posted by Ross Green
Reproduced on Chrome 40 x64 / Windows 8 x64 with Chrome build 1.8.11.1391.

comment:2 Changed 5 years ago by Ross

  • Description modified (diff)

comment:3 Changed 5 years ago by mapx

error in console

Error in event handler for runtime.onMessage: TypeError: Cannot read property 'getAttribute' of null

at getBlockableElementOrAncestor (chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/include.postload.js:398:27)
at chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/include.postload.js:682:60
at Object.EventTarget._dispatch (chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/ext/common.js:51:41)
at chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/ext/content.js:3:24

comment:4 Changed 5 years ago by mapx

  • Cc mapx added
  • Component changed from Unknown to Platform

comment:5 Changed 5 years ago by mapx

  • Cc sebastian added

comment:6 Changed 5 years ago by sebastian

  • Owner set to sebastian
  • Priority changed from Unknown to P2
  • Ready set

Ouch, this regression were introduced with #1282. It happens every time we encounter an image map aka <area> tag. It's just a silly typo in the code, where image is supposed to be images[i] resulting into that error.

comment:7 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:8 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-1.8.12-for-Chrome-Opera-Safari
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.