Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2118 closed change (fixed)

[adblockplus.org Anwiki to CMS migration] Generate TOC

Reported by: saroyanm Assignee: kzar
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: Blocked By: #2119, #2306
Blocking: #2035 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

https://github.com/kzar/adblockplus-website-converter/commit/0acddcf307a4f1febbb6df01d633b66672990e56

Description

Background

We are using "anwtoc" tag to generate table of content list that uses content of the page of it's "page" attribute to generate list of subcontent in the referenced page. Currently it's just getting the id of heading elements in the page and generates list.
You can see the current implementation in abp_output plugin in Anwiki.
Here are the pages that are affected by that:

  • en/android-about
  • en/android-config
  • en/faq

What to change

Update migration script to generate Table of Content according to "anwtoc" tag in anwiki.

Change History (11)

comment:1 Changed 5 years ago by saroyanm

  • Ready set

Currently toclist method in our "CMS" uses HTML as it's attribute, but not path to content.
So I guess we can hardcode "linked TOC" for now, but I think we will need solution for future, so the toclist could also accept path to file, not sure whether it would be easy to achiev within our CMS.

comment:2 Changed 5 years ago by saroyanm

  • Blocked By 2119 added

comment:3 Changed 5 years ago by saroyanm

Replying to saroyanm:

So I guess we can hardcode "linked TOC" for now.

While we will need that solution anyway before large scale update.
I've created "Blocked By" ticket accordingly.

comment:4 Changed 5 years ago by kzar

  • Owner set to kzar
  • Verified working unset

comment:5 Changed 5 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 5 years ago by kzar

  • Review URL(s) modified (diff)

comment:7 Changed 5 years ago by kzar

  • Blocked By 2306 added

comment:8 Changed 5 years ago by kzar

  • Review URL(s) modified (diff)

comment:9 Changed 5 years ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:11 Changed 5 years ago by Ross

  • Verified working set

Implemented and working.

Tested by:
Running the website converter script as per the read me and checking the TOC output for the mentioned pages.

Tested with:
www / r18024
sitescripts / r501
web.adblockplus.org / r68
website-converter / master / 105208883c4336a3788820fe9ab379cf639f8387

Note: See TracTickets for help on using tickets.