Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#2120 closed change (fixed)

[adblockplus.org Anwiki to CMS migration] implement animations

Reported by: saroyanm Assignee: kzar
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: Blocked By:
Blocking: #2035 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

http://codereview.adblockplus.org/4661048523096064/
https://github.com/kzar/adblockplus-website-converter/compare/2120-animations?expand=1

Description (last modified by kzar)

Background

In Anwiki we have a special animation tag. Anwiki loads the animation.js script on any page that uses it.
Also, each animation has a xml document with animation instructions, these instructions are loaded based on the name attribute of animation tag.

What to change

adblockplus-website-converter:

  1. Update the refresh-static-files script to download https://adblockplus.org/animation.js.
  2. Update the convert.py script to process files starting with animation! in a similar way to how interfaces, pages etc are processed. Output should mostly match the XML served by Anwiki. (However _don't_ update image <object> tags to use data URLs, instead wrap the src URL with a call to the inline_image filter.)
  3. Update the convert.py script so that animation.js is included on any page that contains an <animation> tag.

web.adblockplus.org

  1. Add a filter called inline_image that takes an image path and returns a data URL of the image's contents. Be sure to allow both localised (eg static/image/example.png) and non-localised (eg locales/en/images/example.png) images.

Change History (7)

comment:1 Changed 4 years ago by kzar

  • Owner set to kzar
  • Verified working unset

comment:2 Changed 4 years ago by kzar

  • Description modified (diff)

Unfortunately there's more to this than copying the files over, Anwiki appears to process the XML files. For example compare the anim_addicon.xml that is served online to the one under source control.

I've updated the description accordingly.

comment:3 Changed 4 years ago by kzar

  • Description modified (diff)

comment:4 Changed 4 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 4 years ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 4 years ago by Ross

  • Verified working set

Implemented and working except in IE9 (opened as #2519).

Tested by:
Checking animations work/play on the FAQ pages.

Tested on:
https://beta.adblockplus.org/en/faq_basics#blocking

Tested with:

IE8.0.6001Windows XP
IE9.0.8112Windows 7
IE10.0.9200Windows 7
IE11.0.9600Windows 8.1
Chrome42.0.2311.135Windows 8.1
Opera29.0.1795.47Windows 8.1
Firefox37.0.2Windows 8.1
Safari7.0OSX 10.9
Chrome42.0.3211.111Android 4.4.2
Firefox Mobile29.0.1Android 4.4.2
Browser4.4.2-15Android 4.4.2
Last edited 4 years ago by Ross (previous) (diff)
Note: See TracTickets for help on using tickets.