Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#2139 closed change (fixed)

[cms] Allow nested translations for tag attributes

Reported by: trev Assignee: kzar
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: #2140 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6440550915899392/

Description (last modified by kzar)

Background

Currently, you have no way but to break up a string if a link needs to be translated:

{{str1 There is more}} <a href="{{link http://example.com/}}">{{str2 information}}</a> {{str3 available on this.}}

This is very suboptimal as the three parts of the sentence have to be translated separately.

What to change

Allow nested translations, for tag attributes, so that something like this will work:

{{str There is more <a href="{{link http://example.com/}}">information</a> available on this.}}

So only the string There is more <a>information</a> available on this. should be translated in addition to the link target.

Note. Translations are not allowed to alter the order of tags in the string, so we do not need to handle that.

Change History (10)

comment:1 Changed 5 years ago by trev

  • Blocking 2140 added

comment:2 Changed 4 years ago by kzar

  • Owner set to kzar
  • Verified working unset

comment:3 Changed 4 years ago by kzar

@palant Do we only care about nested translations because we want to allow translatable URLs in links? If so how about we do this instead:

  • Pick some arbitrary prefix for URLs in page templates that indicates that they are translatable. For example we could pick "!" so your example would look like {{str There is more <a href="!http://example.com/">information</a> available on this.}}. (Or a Markdown equivalent would look like {{str There is more [information](!http://example.com/) available on this.}}.)
  • Store translatable links in locale files as an array along with their corresponding text. So to continue our example a locale file might look like {"str": {"message": "There is more <a>information</a> available on this.", "links": ["http://example.com/"]}} instead of {"str": {"message": "There is more <a>information</a> available on this."}, "link": {"message": "http://example.com"}}. I think that would make much more sense and be easier for translators to understand, otherwise it's going to get confusing fast trying to keep track of which translation strings correspond with which translatable URLs. (In any case we would have to come up with some convention like "str_link_1" for the string names of translatable links.)

What do you think?

comment:4 Changed 4 years ago by trev

We currently only need this functionality for <a href="">, yes. However, I don't really like hardcoding this as a limitation of the system, meaning that <a title=""> will just not be possible. And what if we decide to allow images within localizable strings?

The proposed syntax also has disadvantages: while being visually simpler, it means introducing special syntax for this (rather uncommon) scenario. And I dislike that the string name cannot be specified explicitly - this will bite us at the latest when we get a string with two translatable links. No, we cannot just change the format of the locale files - Crowdin has to support it.

So altogether this doesn't seem to be worth it. We can limit this to full attributes however, things should be only marginally more complicated then.

Last edited 4 years ago by trev (previous) (diff)

comment:5 Changed 4 years ago by kzar

@palant Fair enough, next question then is how do we figure out where nested translatable strings should be placed inside the parent string for translations? It seems like we need some marker like {{child_str_name}} inside the parent string. So for example {"str": {"message": "There is more <a href='{{str_link_1}}'>information</a> available on this."}, "str_link_1": {"message": "http://example.com"}}.

It seems like an unnecessary layer of indirection though, surely we might as well just have the nested string inside the parent string directly, so something like {"str": {"message": "There is more <a href='http://example.com'>information</a> available on this."}}.

Thing is to allow that we would then be back to requiring a special syntax in the page template to indicate that an attribute is translatable. (Perhaps we could prefix translatable attributes with "!" or similar after all?)

comment:6 Changed 4 years ago by trev

We already have that information in the page, we don't need to duplicate it in the string as well. If the page says {{Click <a href="http://foo/">here</a> or <a id="barlink" href="http://bar/">here</a> please.}} then the translatable string will be Click <a>here</a> or <a>here</a> please. So how does the code know where href="http://foo/" goes? Right, the first <a> tag, because that's where it is in the page. And where does id="barlink" go? The second <a> tag of course. That logic is already implemented - it only needs to be extended by translatable attributes.

comment:7 Changed 4 years ago by kzar

  • Description modified (diff)
  • Summary changed from [cms] Allow nested translations to [cms] Allow nested translations for tag attributes

OK so after a discussion in IRC it turns out that translated texts are not allowed to change the order of tags. I didn't realise that, hence the confusion about how we'll know where translatable attributes get placed. Updated the ticket description to reflect my understanding.

comment:8 Changed 4 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

(Whoops, forgot to set this as reviewing earlier!)

comment:9 Changed 4 years ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.