Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#2140 closed change (fixed)

[adblockplus.org Anwiki to CMS migration] Make sure translatable links don't break up strings

Reported by: trev Assignee: kzar
Priority: P3 Milestone:
Module: Websites Keywords: 2015q2
Cc: Blocked By: #2139
Blocking: #2035 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

https://github.com/kzar/adblockplus-website-converter/commit/04eeb734d920822d4f8604c7a3c3ec49d995f946

Description

Background

Currently, a translatable link in the middle of a sentence will break up the sentence into three separate strings. This is very suboptimal.

What to change

Once #2139 is fixed, generate markup like {{str There is more <a href="{{link http://example.com/}}">information</a> available on this.}} for translatable strings.

Change History (5)

comment:1 Changed 4 years ago by fhd

  • Keywords 2015q2 added
  • Verified working unset

comment:2 Changed 4 years ago by kzar

  • Owner set to kzar

comment:3 Changed 4 years ago by kzar

  • Resolution set to fixed
  • Review URL(s) modified (diff)
  • Status changed from new to closed

comment:5 Changed 4 years ago by Ross

  • Verified working set

Working.

Tested by:
Running the website converter script as per the read me and checking the output for translatable links.

Tested with:
www / r18024
sitescripts / r501
web.adblockplus.org / r68
website-converter / master / 105208883c4336a3788820fe9ab379cf639f8387

Note: See TracTickets for help on using tickets.