Opened 6 years ago

Last modified 6 years ago

#2141 new change

Clean up: initializing of s_mimeFilter in CPluginClass::OnBeforeNavigate2

Reported by: sergz Assignee:
Priority: P4 Milestone:
Module: Adblock-Plus-for-Internet-Explorer Keywords: goodfirstbug
Cc: sergz, oleksandr Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):



  • we don't need s_mimeFilter = CPluginClientFactory::GetMimeFilterClientInstance(); in OnBeforeNavigate2 because it's always registered in SetSite
  • it's even not protected

What to change

Just remove it.

Change History (2)

comment:1 Changed 6 years ago by oleksandr

  • Cc sergz oleksandr added
  • Platform changed from Unknown to Internet Explorer
  • Priority changed from Unknown to P4
  • Ready set

It is there in case for some reason registering the mime filter didn't happen before the navigation. I would leave it just in case. However it does get called now: when blocking is disabled everywhere and a user is navigating to a webpage. This probably needs to be fixed so that it wouldn't register mime filter if it doesn't need to.

comment:2 Changed 6 years ago by oleksandr

  • Keywords goodfirstbug added
Note: See TracTickets for help on using tickets.