Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2144 closed defect (fixed)

[adblockplus.org Anwiki to CMS migration] get_subscriptions filter expects a local subscriptionlist repository

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: Blocked By:
Blocking: #2035 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

http://codereview.adblockplus.org/5662732741246976/

Description

How to reproduce

  1. Run test server on a computer without a sitescripts.ini file.
  2. Open http://localhost:5000/en/subscriptions

Observed behaviour

An error message complains about a missing sitescripts.ini file.

Expected behaviour

The page should show up correctly.

Background

get_subscriptions filter uses sitescripts.subscriptions.subscriptionParser. This module currently expects to work with a local subscriptionlist repository. While we already override this behavior when it comes to retrieving the list of subscriptions, it still tries to get a settings file from a local (and non-existent) repository.

What to change

Patch up sitescripts.subscriptions.subscriptionParser to download the file from https://hg.adblockplus.org/subscriptionlist/rawfile/default/settings.

Change History (3)

comment:1 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 5 years ago by Ross

  • Verified working set

Fixed/done.

Tested by:
Running a test server without sitescripts.ini. It downloads required files successfully and displays the subscriptions page.

Note: See TracTickets for help on using tickets.