Opened 5 years ago

Closed 2 years ago

Last modified 12 months ago

#2148 closed change (fixed)

Rewrite the testpages test suite

Reported by: Ross Assignee: Ross
Priority: P5 Milestone:
Module: Unknown Keywords:
Cc: philll, Ross Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Ross Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29755578/

Description (last modified by Ross)

Background

We want static, simple, self-hosted test pages for testing various ABP filter functionality. A repository already exists for serving these.

What to change

  • Make layout mobile friendly.
  • Remove old test suite pages.
  • Add test cases covering all filters types and exceptions.
  • Ensure all test case filters can be active at the same time.
  • Clean up CSS.

Change History (12)

comment:1 Changed 5 years ago by Ross

  • Description modified (diff)

Updated description to be a better specification of what is required.

Last edited 5 years ago by Ross (previous) (diff)

comment:2 Changed 5 years ago by Ross

  • Description modified (diff)

comment:3 Changed 5 years ago by Ross

  • Description modified (diff)
  • Verified working unset

comment:4 Changed 5 years ago by Ross

  • Description modified (diff)

comment:5 Changed 5 years ago by Ross

  • Description modified (diff)
  • Ready set
  • Tester set to Ross

I've updated this ticket to match what has eventually become the first set of test suite pages. I've created other tickets for updating/improvement of the other sections: #2840 and #2841.

comment:6 Changed 4 years ago by juliandoucette

@ross this ticket is aging. I would suggest lowering it's priority or breaking it up into smaller chunks if it's not going to get done. Please reach out to us if you need help.

Version 0, edited 4 years ago by juliandoucette (next)

comment:7 Changed 3 years ago by juliandoucette

  • Cc Ross added
  • Priority changed from P3 to P5

comment:8 Changed 3 years ago by juliandoucette

  • Component changed from Websites to Unknown

comment:9 Changed 2 years ago by Ross

  • Description modified (diff)
  • Summary changed from Create initial test pages for test suite to Update test pages with testcases for filter types

comment:10 Changed 2 years ago by Ross

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
  • Summary changed from Update test pages with testcases for filter types to Rewrite the testpages test suite

comment:13 Changed 2 years ago by Ross

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.