Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#2151 closed defect (fixed)

$sitekey ignored for $elemhide filters

Reported by: greiner Assignee: greiner
Priority: P1 Milestone: Adblock-Plus-2.6.9-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

​http://codereview.adblockplus.org/5296291500261376/

Description

Environment

Firefox 36.0.1
Adblock Plus 2.6.8.3914

How to reproduce

  1. Add the following custom filter: @@*$elemhide,sitekey=MHwwDQYJKoZIhvcNAQEBBQADawAwaAJhALky0YRGoxmI1Wj/uDqZwxIfLA4oU/0pT09NC4IyT87Esd4jJU6TIQL9sg1L2KHyg8MD4gY9GWoFNLR2j+0cWIhihnFscBQTUxsSM/uzJF8jqK5FVaR4pyYunqGr+uJ+qQIDAQAB
  2. Go to ​http://muvie.com
  3. Open blockable items panel

Observed behaviour

The blockable items list show one or more element hiding filter as active on the page.

Expected behaviour

The blockable items list shows no element hiding filters as active on the page.

Background

This issue goes back to #432 which made use of the new $sitekey behavior ,as introduced in #431, in the Firefox version.

What to change

Append the sitekey as an additional parameter to the following call in lib/contentPolicy.js:
match = defaultMatcher.matchesAny(testWndLocation, "ELEMHIDE", parentDocDomain, false);

Change History (5)

comment:1 Changed 5 years ago by trev

  • Platform changed from Unknown to Firefox/Firefox Mobile
  • Priority changed from Unknown to P1
  • Ready set

comment:2 Changed 5 years ago by greiner

  • Owner set to greiner

comment:3 Changed 5 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 5 years ago by greiner

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/adblockplus/rev/24a1d79fec93

comment:5 Changed 4 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Note: See TracTickets for help on using tickets.