Opened on 03/16/2015 at 04:22:05 PM

Closed on 03/20/2015 at 06:26:31 PM

Last modified on 05/20/2015 at 02:22:39 PM

#2151 closed defect (fixed)

$sitekey ignored for $elemhide filters

Reported by: greiner Assignee: greiner
Priority: P1 Milestone: Adblock-Plus-2.6.9-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):



Firefox 36.0.1
Adblock Plus

How to reproduce

  1. Add the following custom filter: @@*$elemhide,sitekey=MHwwDQYJKoZIhvcNAQEBBQADawAwaAJhALky0YRGoxmI1Wj/uDqZwxIfLA4oU/0pT09NC4IyT87Esd4jJU6TIQL9sg1L2KHyg8MD4gY9GWoFNLR2j+0cWIhihnFscBQTUxsSM/uzJF8jqK5FVaR4pyYunqGr+uJ+qQIDAQAB
  2. Go to
  3. Open blockable items panel

Observed behaviour

The blockable items list show one or more element hiding filter as active on the page.

Expected behaviour

The blockable items list shows no element hiding filters as active on the page.


This issue goes back to #432 which made use of the new $sitekey behavior ,as introduced in #431, in the Firefox version.

What to change

Append the sitekey as an additional parameter to the following call in lib/contentPolicy.js:
match = defaultMatcher.matchesAny(testWndLocation, "ELEMHIDE", parentDocDomain, false);

Attachments (0)

Change History (5)

comment:1 Changed on 03/20/2015 at 06:04:29 PM by trev

  • Platform changed from Unknown to Firefox/Firefox Mobile
  • Priority changed from Unknown to P1
  • Ready set

comment:2 Changed on 03/20/2015 at 06:14:29 PM by greiner

  • Owner set to greiner

comment:3 Changed on 03/20/2015 at 06:14:42 PM by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 03/20/2015 at 06:26:31 PM by greiner

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 05/20/2015 at 02:22:39 PM by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from greiner.
Note: See TracTickets for help on using tickets.