Opened 5 years ago

Closed 5 years ago

#2183 closed defect (fixed)

Create gae2django and rietveld clone

Reported by: matze Assignee:
Priority: P3 Milestone:
Module: Infrastructure Keywords:
Cc: palant, fhd, fred Blocked By:
Blocking: #2182 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by trev)

In order to ensure the availability of the Rietveld source for our infrastructure, we have to clone the upstream repositories at and into and respectively - ideally prior to migrating to our own instance.

Change History (7)

comment:1 Changed 5 years ago by matze

Just realized the same should be done for as well. There's no need for an explicit ticket, this can be done in the context of this very issue here.

comment:2 Changed 5 years ago by matze

  • Description modified (diff)
  • Summary changed from Create Rietveld Clone to Create gae2django and rietveld clone
  • Verified working unset

comment:3 Changed 5 years ago by trev

  • Description modified (diff)

comment:4 Changed 5 years ago by matze

Repositories have been created, initial commits have been made:

comment:5 Changed 5 years ago by matze

For documentation purpose:

It seems like gae2django has been discontinued in May 2012. Thus, recent versions of rietveld cannot be used. In particular, I have found two major issues that reoccur at installation time:

  • The patch-files in gae2django/examples/rietveld/patches fail to apply. Especially patches for rietveld template-files are a problem, because here the most changes have been applied in the last years.
  • Some symbols provided by the Google AppEngine and used by rietveld are not available, e.g. {google,gaeapi}.appengine.db.StringListProperty. In fact there are even rietveld versions prior to 2012 that use this class, so this has been a missing feature in gae2django before.

I've nailed it down to 214 versions of rietveld where none of the above issues occur (according to shell-foo, I have not tested them all). The most recent of those is from November 2012. There've been a few minor issues, like missing variables in the file, but those could easily get solved (see the codereview later).

comment:6 Changed 5 years ago by matze

  • Cc palant fhd fred added
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 5 years ago by matze

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.